zhijiangW commented on a change in pull request #11218: [FLINK-16285][network]
Refactor SingleInputGate#setInputChannel to remove
IntermediateResultPartitionID argument
URL: https://github.com/apache/flink/pull/11218#discussion_r385175454
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -322,9 +322,10 @@ public void assignExclusiveSegments() throws IOException {
}
}
- public void setInputChannel(IntermediateResultPartitionID partitionId,
InputChannel inputChannel) {
+ public void setInputChannel(InputChannel inputChannel) {
+ IntermediateResultPartitionID partitionId =
checkNotNull(inputChannel).partitionId.getPartitionId();
Review comment:
I would make `checkNotNull` in separate line and use getter for
`partitionId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
