wangyang0918 commented on a change in pull request #11233: [FLINK-16194][k8s]
Refactor the Kubernetes decorator design
URL: https://github.com/apache/flink/pull/11233#discussion_r385612691
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -66,8 +70,52 @@ public Fabric8FlinkKubeClient(Configuration flinkConfig,
KubernetesClient client
}
@Override
- public void createTaskManagerPod(TaskManagerPodParameter parameter) {
- // todo
+ public void createJobManagerComponent(KubernetesJobManagerSpecification
kubernetesJMSpec) {
+ final Deployment deployment = kubernetesJMSpec.getDeployment();
+ final List<HasMetadata> accompanyingResources =
kubernetesJMSpec.getAccompanyingResources();
+
+ // create Deployment
+ LOG.debug("Start to create deployment with spec {}",
deployment.getSpec().toString());
+ final Deployment createdDeployment = this.internalClient
Review comment:
We create the deployment first, then the accompanyingResources(e.g.
configmap, service) are created. Does it have chance that the deployment is
created with failure? Because the it needs to mount an nonexistent `ConfigMap`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
