wangyang0918 commented on a change in pull request #11233: [FLINK-16194][k8s]
Refactor the Kubernetes decorator design
URL: https://github.com/apache/flink/pull/11233#discussion_r385615804
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesClusterDescriptorTest.java
##########
@@ -47,19 +55,29 @@
* Tests for the {@link KubernetesClusterDescriptor}.
*/
public class KubernetesClusterDescriptorTest extends KubernetesTestBase {
-
+ private static final String MOCK_SERVICE_HOST_NAME =
"mock-host-name-of-service";
private static final String MOCK_SERVICE_IP = "192.168.0.1";
private final ClusterSpecification clusterSpecification = new
ClusterSpecification.ClusterSpecificationBuilder()
.createClusterSpecification();
+ @Before
+ public void setup() throws Exception {
+ super.setup();
+
+ mockRestServiceWithLoadBalancer(MOCK_SERVICE_HOST_NAME,
MOCK_SERVICE_IP);
+ }
+
@Test
public void testDeploySessionCluster() throws Exception {
+ mockRestServiceWithLoadBalancer(MOCK_SERVICE_HOST_NAME,
MOCK_SERVICE_IP);
Review comment:
`mockRestServiceWithLoadBalancer` could be removed. It has been called in
the `setup`. Other tests is in the same situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
