afedulov commented on a change in pull request #11195: [FLINK-16222][runtime]
Use plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r386604078
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java
##########
@@ -120,55 +124,37 @@ public static ReporterSetup forReporter(String
reporterName, MetricConfig metric
}
private static ReporterSetup createReporterSetup(String reporterName,
MetricConfig metricConfig, MetricReporter reporter) {
- LOG.info("Configuring {} with {}.", reporterName, metricConfig);
+ LOG.debug("Configuring {} with {}.", reporterName,
metricConfig);
Review comment:
Good point. I am not 100% sure about it - do we have a Flink-wide way to
handle such cases? I guess the cleanest approach would be to have a special set
of keys that are considered sensitive, which have to be obfuscated prior to
logging. Seeing which other config values are used during the initialization
could be generally pretty useful for debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
