afedulov commented on a change in pull request #11195: [FLINK-16222][runtime]
Use plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r386644501
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -119,7 +120,7 @@
private boolean shutdown;
- public TaskManagerRunner(Configuration configuration, ResourceID
resourceId) throws Exception {
+ public TaskManagerRunner(Configuration configuration, ResourceID
resourceId, PluginManager pluginManager) throws Exception {
Review comment:
I am not sure what should be the expected contract here. ReporterSetup will
currently only work with the null pluginManager if no reporters are configured
(namedReporters.isEmpty()). We could maybe add a checkNonNull in the
ReporterSetup after the first return due to empty namedReporters.
(TaskManagerRunnerTest is now fixed to initialize the PluginManager
properly)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
