xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388865070
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -804,22 +808,31 @@ private boolean
isFulfillableByRegisteredSlots(ResourceProfile resourceProfile)
}
private Optional<PendingTaskManagerSlot>
allocateResource(ResourceProfile resourceProfile) {
- final Collection<ResourceProfile> requestedSlots =
resourceActions.allocateResource(resourceProfile);
+ if (workerResourceSpec == null) {
+ // standalone mode, cannot allocate resource
Review comment:
The problem is not about calling `StandaloneResourceManager#startNewWorker`.
It is about not having a `WorkerResourceSpec` on standalone setups.
For a standalone cluster, use may have TM resource configurations only on
the TM machines. That means trying to create a `WorkerResourceSpec` from the
configuration on JM might lead to failures due to missing of memory
configurations. I think it does not make sense to force the users to set TM
configurations on the JM machine, because they are not really used.
We have run into such problems during the 1.9 release testing, where a
standalone JM failed because it tries to calculate a default TM managed memory
size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
