xintongsong commented on issue #11320: [FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager at the worker granularity. URL: https://github.com/apache/flink/pull/11320#issuecomment-595753573 Thanks for the review, @wangyang0918 and @TisonKun. @wangyang0918, regarding where to create `defaultWorkerResourceSpec`: - First, it is created in `ActiveResourceManagerFactory`, before creating `SlotManager` and using it to create `ResourceManager`. To that end, I think `ResourceManager` is still not aware of `defaultWorkerResourceSpec`. - One reason for not creating `defaultWorkerResourceSpec` in `SlotManagerConfiguration`, is that we need to decide whether to create it or not according to the deployment. We should only create it for active RM setups. See my reply on the detailed comment. - Another reason is that, we need to use different configurations per RM to decide the cpu cores of the `defaultWorkerResourceSpec`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
