xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388878181
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -804,22 +808,31 @@ private boolean
isFulfillableByRegisteredSlots(ResourceProfile resourceProfile)
}
private Optional<PendingTaskManagerSlot>
allocateResource(ResourceProfile resourceProfile) {
- final Collection<ResourceProfile> requestedSlots =
resourceActions.allocateResource(resourceProfile);
+ if (workerResourceSpec == null) {
+ // standalone mode, cannot allocate resource
Review comment:
@TisonKun
Please see my reply to Yang for why calling `allocateResource` on standalone
setup. For the same reason, we cannot merge this into the `if
(!resourceActions.allocateResource(workerResourceSpec))` branch.
Regarding `slotResourceProfile`, `resourceProfile` and `workerResourceSpec`.
- `slotResourceProfile` describes the resource capacity of a slot.
- `resourceProfile` describes the resource requirement of a slot request.
- `workerResourceSpec` describes the resource requirement of a worker (TM)
to request.
I think you're right, these things are indeed hard to understand. How do you
think about renaming `resourceProfile` to `requestedSlotResourceProfile`, and
`slotResourceProfile` to `defaultSlotResourceProfile`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
