Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46173139
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -254,13 +262,14 @@ public ExecutionGraph(
ExecutionContext executionContext,
JobID jobId,
String jobName,
+ JobType jobType,
Configuration jobConfig,
FiniteDuration timeout,
List<BlobKey> requiredJarFiles,
List<URL> requiredClasspaths,
ClassLoader userClassLoader) {
- if (executionContext == null || jobId == null || jobName ==
null || jobConfig == null || userClassLoader == null) {
+ if (executionContext == null || jobId == null || jobName ==
null || jobType == null || jobConfig == null || userClassLoader == null) {
throw new NullPointerException();
--- End diff --
I think it would be good to know which of the fields was actually `null`.
We could use
```
executionContext = Preconditions.checkNotNull(executionContext);
...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
