Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r46205018
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1, 
JobStatusMessage o2) {
        }
     
        /**
    +    * Executes the STOP action.
    +    * 
    +    * @param args Command line arguments for the stop action.
    +    */
    +   protected int stop(String[] args) {
    +           LOG.info("Running 'stop' command.");
    +
    +           StopOptions options;
    +           try {
    +                   options = CliFrontendParser.parseStopCommand(args);
    +           }
    +           catch (CliArgsException e) {
    +                   return handleArgException(e);
    +           }
    +           catch (Throwable t) {
    +                   return handleError(t);
    +           }
    +
    +           // evaluate help flag
    +           if (options.isPrintHelp()) {
    +                   CliFrontendParser.printHelpForStop();
    +                   return 0;
    +           }
    +
    +           String[] stopArgs = options.getArgs();
    +           JobID jobId;
    +
    +           if (stopArgs.length > 0) {
    +                   String jobIdString = stopArgs[0];
    +                   try {
    +                           jobId = new 
JobID(StringUtils.hexStringToByte(jobIdString));
    +                   }
    +                   catch (Exception e) {
    +                           LOG.error("Error: The value for the Job ID is 
not a valid ID.");
    +                           System.out.println("Error: The value for the 
Job ID is not a valid ID.");
    +                           return 1;
    +                   }
    +           }
    +           else {
    +                   LOG.error("Missing JobID in the command line 
arguments.");
    --- End diff --
    
    See `cancel` -- same as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to