TisonKun commented on issue #10526: [FLINK-15090][build] Reverse the dependency from flink-streaming-java to flink-client URL: https://github.com/apache/flink/pull/10526#issuecomment-596887194 @aljoscha Thanks for your review! I've addressed your comments inline. For moving test to `flink-tests`, I agree that throwing everything into a full dependencies test module is bad practice. However, these tests don't belong to `flink-client` because they are primarily tests for streaming api. It happens we need to load services that are in `flink-client`. See also ExecutionEnvironment tests in `flink-tests`. If we want to clear dependencies for testing, and for the long term maintenance, I'd prefer re-struct `flink-tests`, `flink-yarn-tests`, `flink-fs-tests` to be under a parent module and separate these env related tests in a sub module.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
