TisonKun commented on a change in pull request #11338: [FLINK-10052][ha]
Tolerate temporarily suspended ZooKeeper connections
URL: https://github.com/apache/flink/pull/11338#discussion_r390916207
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionService.java
##########
@@ -411,8 +411,7 @@ protected void handleStateChange(ConnectionState newState)
{
LOG.debug("Connected to ZooKeeper quorum.
Leader election can start.");
break;
case SUSPENDED:
- LOG.warn("Connection to ZooKeeper suspended.
The contender " + leaderContender.getDescription()
- + " no longer participates in the
leader election.");
+ LOG.warn("Connection to ZooKeeper suspended,
waiting for reconnection.");
Review comment:
Actually since Curator already logs ConnectionState change, I'd prefer
remove these logs.
For the specific question, if we always turn on the feature, the contender
is waiting for reconnection, but it can succeed(RECONNECTED) or fail(LOST).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services