zentol commented on a change in pull request #11361: [FLINK-15727] Let
BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r390924124
##########
File path: flink-dist/src/test/bin/runBashJavaUtilsCmd.sh
##########
@@ -36,5 +36,6 @@ FLINK_DIST_JAR=`find $FLINK_TARGET_DIR -name
'flink-dist*.jar'`
. ${bin}/../../main/flink-bin/bin/config.sh > /dev/null
-output=`runBashJavaUtilsCmd ${COMMAND} ${FLINK_CONF_DIR}
"$FLINK_TARGET_DIR/bash-java-utils.jar:$FLINK_DIST_JAR}"`
-extractExecutionParams "$output"
+output=$(runBashJavaUtilsCmd GET_TM_RESOURCE_PARAMS ${FLINK_CONF_DIR}
"$FLINK_TARGET_DIR/bash-java-utils.jar:$FLINK_DIST_JAR}" | tail -n 2)
+extractExecutionParams "$(echo "$output" | tail -n 2 | head -n 1)"
Review comment:
`head -n 1` should be sufficient since `output` already only contains 2
lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
