zentol commented on a change in pull request #11361: [FLINK-15727] Let
BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r391510520
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJavaUtils.java
##########
@@ -74,13 +70,8 @@ private static Configuration
getConfigurationForStandaloneTaskManagers(String[]
*/
public enum Command {
/**
- * Get dynamic configs of task executor resources.
- */
- GET_TM_RESOURCE_DYNAMIC_CONFIGS,
-
- /**
- * Get JVM parameters of task executor resources.
+ * Get JVM parameters and dynamic configs of task executor
resources.
*/
- GET_TM_RESOURCE_JVM_PARAMS
+ GET_TM_RESOURCE_PARAMS
Review comment:
If this were to happen we'd revert back to having to call it multiple times;
we'd likely just print another line instead, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
