AHeise commented on a change in pull request #11303: [FLINK-16245] Decoupling user classloader from context classloader. URL: https://github.com/apache/flink/pull/11303#discussion_r390953027
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/FlinkUserCodeClassLoaders.java ########## @@ -18,35 +18,44 @@ package org.apache.flink.runtime.execution.librarycache; +import org.apache.flink.annotation.VisibleForTesting; import org.apache.flink.util.ChildFirstClassLoader; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; import java.net.URL; import java.net.URLClassLoader; +import java.util.Enumeration; /** * Gives the URLClassLoader a nicer name for debugging purposes. */ public class FlinkUserCodeClassLoaders { - public static URLClassLoader parentFirst(URL[] urls, ClassLoader parent) { + @VisibleForTesting + static URLClassLoader parentFirst(URL[] urls, ClassLoader parent) { Review comment: I was not considering it initially because delegation pattern on implementation level felt wrong, but it's messy for ClassLoader anyways and it would solve this discussion, so I adjusted the PR. Now we just need to converge on `loadClass`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services