AHeise commented on a change in pull request #11303: [FLINK-16245] Decoupling
user classloader from context classloader.
URL: https://github.com/apache/flink/pull/11303#discussion_r393234335
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -240,7 +240,11 @@ public void closeSession(String sessionId) throws
SqlExecutionException {
}
});
// Remove the session's ExecutionContext from contextMap.
- this.contextMap.remove(sessionId);
+ try {
+ this.contextMap.remove(sessionId).close();
+ } catch (IOException e) {
+ // ignore any throwable to keep the clean up running
Review comment:
Should we then also log on cancelQuery on L237? I tried to keep it symmetric.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
