mxm opened a new pull request #11394: [FLINK-16573] Ensure Kinesis RecordFetcher threads shutdown on cancel URL: https://github.com/apache/flink/pull/11394 ## What is the purpose of the change Ensure that the Kinesis RecordFetcher threads shut down on cancel. The threads may not shut down correctly because they do not check for the running flag in the inner loops. The threads also do not get interrupted because they are not connected to the main task thread. These threads keep lingering around after the job has shut down: ``` Thread 23168: (state = BLOCKED) - java.lang.Object.wait(long) @bci=0 (Compiled frame; information may be imprecise) - org.apache.flink.streaming.connectors.kinesis.util.RecordEmitter.emitRecords() @bci=140, line=209 (Compiled frame) - org.apache.flink.streaming.connectors.kinesis.util.RecordEmitter.run() @bci=18, line=177 (Interpreted frame) - java.lang.Thread.run() @bci=11, line=748 (Compiled frame) ``` ## Brief change log - Check for the `running` flag in the inner loops which showed up in the stack traces we took ## Verifying this change I'm going to verify this change on a cluster.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
