tweise commented on a change in pull request #11394: [FLINK-16573] Ensure
Kinesis RecordFetcher threads shutdown on cancel
URL: https://github.com/apache/flink/pull/11394#discussion_r391855589
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/RecordEmitter.java
##########
@@ -205,6 +205,10 @@ protected void emitRecords() {
}
}
}
+ if (!running) {
Review comment:
This wouldn't be necessary if the thread was interrupted when the fetcher
terminates. Once we confirm that this change has the intended effect, let's
merge it and cherry-pick into the relevant release branches. I will take a look
at improving the thread management in the fetcher as a follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
