igalshilman commented on a change in pull request #58: [FLINK-16254] Support -p 
/ --parallelism command option
URL: https://github.com/apache/flink-statefun/pull/58#discussion_r392564688
 
 

 ##########
 File path: 
statefun-e2e-tests/statefun-e2e-tests-common/src/main/java/org/apache/flink/statefun/e2e/common/StatefulFunctionsAppContainers.java
 ##########
 @@ -142,10 +141,6 @@ public StatefulFunctionsAppContainers(String appName, int 
numWorkers) {
     this.network = Network.newNetwork();
     this.appName = appName;
     this.numWorkers = numWorkers;
-
-    if (numWorkers > 1) {
-      dynamicProperties.set(CoreOptions.DEFAULT_PARALLELISM, numWorkers);
 
 Review comment:
   Do we actually know that the test succeed because of the -p
   This seems to also set the option in the configurations?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to