tzulitai commented on a change in pull request #58: [FLINK-16254] Support -p /
--parallelism command option
URL: https://github.com/apache/flink-statefun/pull/58#discussion_r392565660
##########
File path:
statefun-flink/statefun-flink-launcher/src/main/java/org/apache/flink/statefun/flink/launcher/StatefulFunctionsJobGraphRetriever.java
##########
@@ -113,4 +124,10 @@ private PackagedProgram createPackagedProgram() {
throw new RuntimeException("Unable to construct a packaged program", e);
}
}
+
+ private static int resolveParallelism(int parallelism, Configuration
configuration) {
Review comment:
But I think you have a point -
We should probably when parsing the command line, make sure that the value
provided via `-p` is `>= 1`. That would avoid the problem you mentioned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
