danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r392771442
##########
File path: flink-table/flink-table-planner-blink/pom.xml
##########
@@ -149,20 +138,30 @@ under the License.
<version>${calcite.version}</version>
<exclusions>
<!--
- "mvn dependency:tree" as of Calcite 1.21:
-
- [INFO] +-
org.apache.calcite:calcite-core:jar:1.21.0:compile
- [INFO] | +-
commons-codec:commons-codec:jar:1.10:compile
- [INFO] | +-
org.apache.calcite:calcite-linq4j:jar:1.21.0:compile
- [INFO] | +-
org.apache.commons:commons-lang3:jar:3.3.2:compile
- [INFO] | +-
com.fasterxml.jackson.core:jackson-core:jar:2.10.1:compile
- [INFO] | +-
com.fasterxml.jackson.core:jackson-annotations:jar:2.10.1:compile
- [INFO] | +-
com.fasterxml.jackson.core:jackson-databind:jar:2.10.1:compile
- [INFO] | +-
com.google.guava:guava:jar:19.0:compile
- [INFO] | \-
com.jayway.jsonpath:json-path:jar:2.4.0:compile
+ "mvn dependency:tree" as of Calcite 1.22.0:
+
+ [INFO] +-
org.apache.calcite:calcite-core:jar:1.22.0:compile
+ [INFO] | +-
org.apache.calcite:calcite-linq4j:jar:1.22.0:compile
+ [INFO] | +-
com.fasterxml.jackson.core:jackson-annotations:jar:2.10.1:compile
+ [INFO] | +-
org.apache.calcite.avatica:avatica-core:jar:1.16.0:compile
Review comment:
I agree, thanks. Just to note, i have to keep some of the runtime dependency
because Calcite code uses that, the runtime dependency jar would also package
into flink, so to Flink, the compile and runtime dependency has no difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
