danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r392910139
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/batch/RemoveRedundantLocalSortAggRule.scala
##########
@@ -48,7 +48,9 @@ abstract class RemoveRedundantLocalSortAggRule(
inputOfLocalAgg.getRowType,
localAgg.getGrouping,
localAgg.getAuxGrouping,
- globalAgg.getAggCallToAggFunction,
+ // Use the localAgg agg calls because the global agg call filters was
removed,
+ // See BatchExecSortAggRule for details.
+ localAgg.getAggCallToAggFunction,
Review comment:
Yep, thanks ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
