danny0405 commented on a change in pull request #11424:
[FLINK-16345][table-planner-blink] Fix computed column can not refer row time
attribute column
URL: https://github.com/apache/flink/pull/11424#discussion_r393441467
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/schema/CatalogSourceTable.scala
##########
@@ -78,12 +79,16 @@ class CatalogSourceTable[T](
.getPlanner
.getContext
.unwrap(classOf[FlinkContext])
+ val typeFactory = cluster.getTypeFactory.asInstanceOf[FlinkTypeFactory]
+
+ // erase time indicator types in the rowType
+ val erasedRowType = eraseTimeIndicator(rowType, typeFactory)
val tableSource =
findAndCreateTableSource(flinkContext.getTableConfig.getConfiguration)
val tableSourceTable = new TableSourceTable[T](
relOptSchema,
schemaTable.getTableIdentifier,
- rowType,
+ erasedRowType,
statistic,
Review comment:
Why not just not to generates the TimeIndicator type when doing the row type
inference of `TableSource`, it seems a little tricky to generates first then
remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
