danny0405 commented on a change in pull request #11424: 
[FLINK-16345][table-planner-blink] Fix computed column can not refer row time 
attribute column
URL: https://github.com/apache/flink/pull/11424#discussion_r393446325
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/schema/CatalogSourceTable.scala
 ##########
 @@ -106,7 +111,7 @@ class CatalogSourceTable[T](
     val toRexFactory = flinkContext.getSqlExprToRexConverterFactory
 
     // 2. push computed column project
-    val fieldNames = rowType.getFieldNames.asScala
+    val fieldNames = erasedRowType.getFieldNames.asScala
 
 Review comment:
   I think the right place to fix is the 
`SqlToOperationConverter#createTableSchema`, before we make the computed column 
type inference, the time attribute should be patched up based on the watermark 
definitions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to