wuchong commented on issue #11425: [FLINK-16125][kafka] Remove unnecessary 
zookeeper.connect property validation
URL: https://github.com/apache/flink/pull/11425#issuecomment-600047802
 
 
   Thanks for the contribution @PatrickRen . Could you also remove this line in 
the IT 
case?https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableTestBase.java#L86
   
   Btw, could you also open a PR for release-1.10 ? For 1.10,  I think we can't 
just remove this property, because we still provide 
`Kafka08TableSourceSinkFactory` in 1.10. We can make this property optional for 
0.9+, but required for 0.8 in 1.10.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to