PatrickRen commented on issue #11425: [FLINK-16125][kafka] Remove unnecessary zookeeper.connect property validation URL: https://github.com/apache/flink/pull/11425#issuecomment-600405311 Hi Jark @wuchong , I noticed that if we remove the line you mentioned, the variable `zk` will become unused: https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableTestBase.java#L69 But it is still referenced in part of commented code: https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableTestBase.java#L115 Should I remove the variable `zk`, or keep it in case of those commented code being used in the future? I'm not sure about the purpose of the commented code...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
