wuchong commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r394772193
##########
File path: flink-table/flink-sql-parser/pom.xml
##########
@@ -38,25 +38,39 @@ under the License.
</properties>
<dependencies>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>provided</scope>
+ </dependency>
<dependency>
<groupId>org.apache.calcite</groupId>
<artifactId>calcite-core</artifactId>
<!-- When updating the Calcite version, make sure to
update the dependency exclusions -->
<version>${calcite.version}</version>
<exclusions>
<!--
- "mvn dependency:tree" as of Calcite 1.21:
+ "mvn dependency:tree" as of Calcite 1.22.0:
- [INFO] +-
org.apache.calcite:calcite-core:jar:1.21.0:compile
- [INFO] | +-
org.apache.calcite.avatica:avatica-core:jar:1.15.0:compile
- [INFO] | \-
com.google.guava:guava:jar:19.0:compile
+ [INFO] +-
org.apache.calcite:calcite-core:jar:1.22.0:compile
+ [INFO] | +-
org.apache.calcite.avatica:avatica-core:jar:1.16.0:compile
+ [INFO] | +-
org.apiguardian:apiguardian-api:jar:1.1.0:compile
Review comment:
This is unreasonable from my side, it only contains a single class `@API`.
Why not add such class into Calcite code instead of introduce a dependency...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
