GJL commented on a change in pull request #11250: [FLINK-16302][rest]add log
list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r395621108
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -309,6 +312,25 @@ public TaskExecutor(
return
CompletableFuture.completedFuture(shuffleEnvironment.getPartitionsOccupyingLocalResources().isEmpty());
}
+ @Override
+ public CompletableFuture<Collection<LogInfo>> requestLogList(Time
timeout) {
+ final String logDir =
taskManagerConfiguration.getTaskManagerLogDir();
+ if (logDir != null) {
+ final File[] logFiles = new File(logDir).listFiles();
Review comment:
Unfortunately this is a blocking IO operation in the main thread which is
discouraged. But the code was already broken before as we are uploading the
files in the main thread. I'll have to think about whether this needs to be
addressed immediately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
