zentol commented on a change in pull request #11195: [FLINK-16222][runtime] Use
plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r395617873
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/FlinkDistribution.java
##########
@@ -260,16 +262,26 @@ public void submitSQLJob(SQLJobSubmission job) throws
IOException {
}
public void copyOptJarsToLib(String jarNamePrefix) throws
FileNotFoundException, IOException {
- final Optional<Path> reporterJarOptional;
- try (Stream<Path> logFiles = Files.walk(opt)) {
- reporterJarOptional = logFiles
+ copyOptJars(jarNamePrefix, lib);
+ }
+
+ public void copyOptJarsToPlugins(String jarNamePrefix) throws
FileNotFoundException, IOException {
Review comment:
hmmm that's a bit frustrating; now we have to open up the API to allow
things that people shouldn't be doing; though admittedly we should be able to
test everything a user _might_ do.
A dumb intermediate workaround would be to have 2 variants; one for
copying/moving each.
You will also have to modify `#moveJar` to pass in the file(name at least)
to `#mapJarLocationPath` so that you can introduce the directory for the
individual plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
