tillrohrmann commented on a change in pull request #11408:
[FLINK-15989][FLINK-16225] Improve direct and metaspace out-of-memory error
handling
URL: https://github.com/apache/flink/pull/11408#discussion_r395647124
##########
File path:
flink-tests/src/test/java/org/apache/flink/runtime/util/ExceptionUtilsITCases.java
##########
@@ -42,31 +45,83 @@
* Tests for {@link ExceptionUtils} which require to spawn JVM process and
set JVM memory args.
*/
public class ExceptionUtilsITCases {
+ private static final int DIRECT_MEMORY_SIZE = 1 << 20; // 128Mb
+ private static final int DIRECT_MEMORY_ALLOCATION_PAGE_SIZE = 1024; //
1Kb
+ private static final int DIRECT_MEMORY_PAGE_NUMBER = DIRECT_MEMORY_SIZE
/ DIRECT_MEMORY_ALLOCATION_PAGE_SIZE;
private static final long INITIAL_BIG_METASPACE_SIZE = 128 * (1 << 20);
// 128Mb
@ClassRule
public static final TemporaryFolder TEMPORARY_FOLDER = new
TemporaryFolder();
+ @Test
+ public void testIsDirectOutOfMemoryError() throws IOException,
InterruptedException {
+ String className = DummyDirectAllocatingProgram.class.getName();
+ String out = run(className, Collections.emptyList(),
DIRECT_MEMORY_SIZE, -1);
+ assertThat(out, is(""));
+ }
+
@Test
public void testIsMetaspaceOutOfMemoryError() throws IOException,
InterruptedException {
+ String className = DummyClassLoadingProgram.class.getName();
// load only one class and record required Metaspace
- long okMetaspace = Long.parseLong(run(1,
INITIAL_BIG_METASPACE_SIZE));
+ String normalOut = run(className,
getDummyClassLoadingProgramArgs(1), -1, INITIAL_BIG_METASPACE_SIZE);
+ long okMetaspace = Long.parseLong(normalOut);
// load more classes to cause 'OutOfMemoryError: Metaspace'
- assertThat(run(1000, okMetaspace), is(""));
+ String oomOut = run(className,
getDummyClassLoadingProgramArgs(1000), -1, okMetaspace);
+ assertThat(oomOut, is(""));
}
- private static String run(int numberOfLoadedClasses, long
metaspaceSize) throws InterruptedException, IOException {
- TestProcessBuilder taskManagerProcessBuilder = new
TestProcessBuilder(DummyClassLoadingProgram.class.getName());
- taskManagerProcessBuilder.addJvmArg("-XX:-UseCompressedOops");
-
taskManagerProcessBuilder.addJvmArg(String.format("-XX:MaxMetaspaceSize=%d",
metaspaceSize));
-
taskManagerProcessBuilder.addMainClassArg(Integer.toString(numberOfLoadedClasses));
-
taskManagerProcessBuilder.addMainClassArg(TEMPORARY_FOLDER.getRoot().getAbsolutePath());
+ private static String run(
+ String className,
+ Iterable<String> args,
+ long directMemorySize,
+ long metaspaceSize) throws InterruptedException,
IOException {
+ TestProcessBuilder taskManagerProcessBuilder = new
TestProcessBuilder(className);
+ if (directMemorySize > 0) {
+
taskManagerProcessBuilder.addJvmArg(String.format("-XX:MaxDirectMemorySize=%d",
directMemorySize));
+ }
+ if (metaspaceSize > 0) {
+
taskManagerProcessBuilder.addJvmArg("-XX:-UseCompressedOops");
+
taskManagerProcessBuilder.addJvmArg(String.format("-XX:MaxMetaspaceSize=%d",
metaspaceSize));
+ }
+ for (String arg : args) {
+ taskManagerProcessBuilder.addMainClassArg(arg);
+ }
TestProcess p = taskManagerProcessBuilder.start();
p.getProcess().waitFor();
assertThat(p.getErrorOutput().toString().trim(), is(""));
return p.getProcessOutput().toString().trim();
}
+ private static Collection<String> getDummyClassLoadingProgramArgs(int
numberOfLoadedClasses) {
+ return Arrays.asList(
+ Integer.toString(numberOfLoadedClasses),
+ TEMPORARY_FOLDER.getRoot().getAbsolutePath());
+ }
+
+ /**
+ * Dummy java program to generate Direct OOM.
+ */
+ public static class DummyDirectAllocatingProgram {
Review comment:
```suggestion
public static class DummyDirectMemoryAllocatingProgram {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
