tillrohrmann commented on a change in pull request #11408:
[FLINK-15989][FLINK-16225] Improve direct and metaspace out-of-memory error
handling
URL: https://github.com/apache/flink/pull/11408#discussion_r395640140
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -246,9 +246,11 @@ public void start() throws Exception {
@Override
public void onFatalError(Throwable exception) {
- LOG.error("Fatal error occurred while executing the
TaskManager. Shutting it down...", exception);
+ Throwable enrichedException =
ExceptionUtils.enrichTaskManagerOutOfMemoryError(exception);
+ LOG.error("Fatal error occurred while executing the
TaskManager. Shutting it down...", enrichedException);
- if (ExceptionUtils.isJvmFatalOrOutOfMemoryError(exception)) {
+ if
(ExceptionUtils.isJvmFatalOrOutOfMemoryError(enrichedException) &&
+
!ExceptionUtils.isMetaspaceOutOfMemoryError(enrichedException)) {
Review comment:
Maybe add a comment explaining why it is ok to not fail hard in case of a
metaspace OOM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
