wangyang0918 commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r396259803
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -351,21 +351,21 @@ public static TaskExecutor startTaskManager(
LOG.info("Starting TaskManager with ResourceID: {}",
resourceID);
- InetAddress remoteAddress =
InetAddress.getByName(rpcService.getAddress());
+ InetAddress externalAddress =
InetAddress.getByName(rpcService.getAddress());
Review comment:
@tillrohrmann @xintongsong
FYI
I think we do not have the requirement that other `TMs` need to be able to
resolve a `TM's ` address. For current standalone Flink cluster on K8s, all the
`TMs` could not resolve other's hostname. However, it works pretty well. This
is the case for current master code without external address.
When introducing the external address, i think it is same that we do not
require other `TMs` need to be able to resolve a `TM's ` address.
Correct me if i am wrong somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
