wangyang0918 commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r396385213
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -351,21 +351,21 @@ public static TaskExecutor startTaskManager(
LOG.info("Starting TaskManager with ResourceID: {}",
resourceID);
- InetAddress remoteAddress =
InetAddress.getByName(rpcService.getAddress());
+ InetAddress externalAddress =
InetAddress.getByName(rpcService.getAddress());
Review comment:
I agree with you that if the `TM` could not resolve its own address, it will
fail. Indeed, it is problem we need to fix in this PR. However, i am just
wondering given that we have fix this and do not require the `TM` could resolve
its own external hostname, do we still need other `TMs` could resolve the
external hostname?
In my opinion every `TM` registers to the `JM` with hostname and ip. So all
the `TMs` could get other `TM` hostname and ip. I am not sure about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
