azagrebin commented on a change in pull request #11245:
[FLINK-15794][Kubernetes] Generate the Kubernetes default image version
URL: https://github.com/apache/flink/pull/11245#discussion_r396339439
##########
File path: flink-runtime/pom.xml
##########
@@ -402,6 +402,59 @@ under the License.
</configuration>
</plugin>
+ <plugin>
+
<groupId>com.google.code.maven-replacer-plugin</groupId>
Review comment:
I am still trying to understand the motivation for introducing the code
generation.
I commented about the existing version implementations.
Anyways if we decide to introduce a dependency on the maven code generation
in the runtime module,
this probably deserves a separate JIRA issue and discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
