azagrebin commented on a change in pull request #11245:
[FLINK-15794][Kubernetes] Generate the Kubernetes default image version
URL: https://github.com/apache/flink/pull/11245#discussion_r396338064
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java
##########
@@ -41,14 +44,19 @@
public static final String UNKNOWN = "<unknown>";
/**
- * Returns the version of the code as String. If version == null, then
the JobManager does not run from a
- * Maven build. An example is a source code checkout, compile, and run
from inside an IDE.
- *
- * @return The version string.
+ * Returns the version of the code as String.
+ * @return The project version string.
*/
public static String getVersion() {
- String version =
EnvironmentInformation.class.getPackage().getImplementationVersion();
- return version != null ? version : UNKNOWN;
+ return PROJECT_VERSION;
+ }
+
+ /**
+ * Returns the version of the used Scala compiler as String.
+ * @return The scala version string.
+ */
+ public static String getScalaVersion() {
+ return SCALA_VERSION;
Review comment:
Can we just use `scala.util.Properties.versionNumberString()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
