StephanEwen commented on a change in pull request #11463: FLINK-16697 - Disable
JMX rebinding
URL: https://github.com/apache/flink/pull/11463#discussion_r396660955
##########
File path:
flink-metrics/flink-metrics-jmx/src/main/java/org/apache/flink/metrics/jmx/JMXReporter.java
##########
@@ -541,5 +552,40 @@ public void stop() throws IOException {
}
}
}
+
+ /*
+ * Better to use the internal API than re-invent the wheel.
+ */
+ @SuppressWarnings("restriction")
+ private class JmxRegistry extends sun.rmi.registry.RegistryImpl
{
Review comment:
With Java 9+ and the module system, access to such internal classes is
harder (gives a strong warning, may be not possible in the future). Could one
rewrite this code to wrap an existing registry and delegate all method calls,
rather than to extend from this class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
