StephanEwen commented on a change in pull request #11463: FLINK-16697 - Disable
JMX rebinding
URL: https://github.com/apache/flink/pull/11463#discussion_r396666923
##########
File path:
flink-metrics/flink-metrics-jmx/src/main/java/org/apache/flink/metrics/jmx/JMXReporter.java
##########
@@ -518,9 +525,13 @@ private void startJmxService(int port) throws IOException
{
throw new IllegalArgumentException("Malformed
service url created " + serviceUrl, e);
}
- connector =
JMXConnectorServerFactory.newJMXConnectorServer(url, null,
ManagementFactory.getPlatformMBeanServer());
+ rmiServer = new RMIJRMPServerImpl(port, null, null,
null);
+
+ // Create the connector server now.
+ connector = new RMIConnectorServer(url, null,
rmiServer, ManagementFactory.getPlatformMBeanServer());
Review comment:
Similar as the above comment: Does this one here need to be explicitly
closed in the `stop()` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
