rkhachatryan commented on a change in pull request #11486: [FLINK-16712][task]
Refactor StreamTask to construct final fields
URL: https://github.com/apache/flink/pull/11486#discussion_r396993073
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -260,17 +258,28 @@ protected StreamTask(
@Nullable TimerService timerService,
Thread.UncaughtExceptionHandler
uncaughtExceptionHandler,
StreamTaskActionExecutor actionExecutor,
- TaskMailbox mailbox) {
+ TaskMailbox mailbox) throws Exception {
Review comment:
Hmm..I meant that we could match something other than `FlinkException`, but
it is wrapped into `FlinkException`.
I checked it again and found only one such case: `c` on line 776 (`Task`).
So if it is thrown somewhere in constructor of `StreamTask` or its
descendants then `Task` will be failed, not cancelled. Currently, it is not
thrown in any of constructors though.
I think we can ignore this issue for now. And if `CancelTaskException` will
be added to constructor, IMO we should rather revisit this cancelation
mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
