rkhachatryan commented on a change in pull request #11486: [FLINK-16712][task]
Refactor StreamTask to construct final fields
URL: https://github.com/apache/flink/pull/11486#discussion_r397023896
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -260,17 +258,28 @@ protected StreamTask(
@Nullable TimerService timerService,
Thread.UncaughtExceptionHandler
uncaughtExceptionHandler,
StreamTaskActionExecutor actionExecutor,
- TaskMailbox mailbox) {
+ TaskMailbox mailbox) throws Exception {
super(environment);
- this.timerService = timerService;
- this.uncaughtExceptionHandler =
Preconditions.checkNotNull(uncaughtExceptionHandler);
this.configuration = new StreamConfig(getTaskConfiguration());
this.recordWriter = createRecordWriterDelegate(configuration,
environment);
this.actionExecutor =
Preconditions.checkNotNull(actionExecutor);
this.mailboxProcessor = new
MailboxProcessor(this::processInput, mailbox, actionExecutor);
this.asyncExceptionHandler = new
StreamTaskAsyncExceptionHandler(environment);
+ this.asyncOperationsThreadPool = Executors.newCachedThreadPool(
+ new ExecutorThreadFactory("AsyncOperations",
uncaughtExceptionHandler));
+
+ this.stateBackend = createStateBackend();
+ this.checkpointStorage =
stateBackend.createCheckpointStorage(getEnvironment().getJobID());
+
+ // if the clock is not already set, then assign a default
TimeServiceProvider
+ if (timerService == null) {
+ ThreadFactory timerThreadFactory = new
DispatcherThreadFactory(TRIGGER_THREAD_GROUP, "Time Trigger for " + getName());
+ this.timerService = new
SystemProcessingTimeService(this::handleTimerException, timerThreadFactory);
+ } else {
Review comment:
I meant that the timer thread could access `asyncExceptionHandler` variable.
So, if someone later reorders it like this:
```
StreamTask(){
this.timerService = new
SystemProcessingTimeService(this::handleTimerException, timerThreadFactory);
this.asyncExceptionHandler = new
StreamTaskAsyncExceptionHandler(environment);
}
...
/// schedule task
```
and removes `final` from `asyncExceptionHandler` then `timerService` thread
can see `null` even **after** it's assigned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
