twalthr commented on a change in pull request #11280: [FLINK-16377][table]
Support inline user defined functions in expression dsl
URL: https://github.com/apache/flink/pull/11280#discussion_r397250326
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/CalculatedQueryOperation.java
##########
@@ -33,34 +34,34 @@
* Describes a relational operation that was created from applying a {@link
TableFunction}.
*/
@Internal
-public class CalculatedQueryOperation<T> implements QueryOperation {
+public class CalculatedQueryOperation implements QueryOperation {
- private final TableFunction<T> tableFunction;
+ private final FunctionDefinition functionDefinition;
+ private final FunctionIdentifier functionIdentifier;
private final List<ResolvedExpression> parameters;
- private final TypeInformation<T> resultType;
private final TableSchema tableSchema;
public CalculatedQueryOperation(
- TableFunction<T> tableFunction,
+ FunctionDefinition functionDefinition,
+ FunctionIdentifier functionIdentifier,
List<ResolvedExpression> parameters,
- TypeInformation<T> resultType,
TableSchema tableSchema) {
- this.tableFunction = tableFunction;
+ this.functionDefinition = functionDefinition;
+ this.functionIdentifier = functionIdentifier;
this.parameters = parameters;
- this.resultType = resultType;
this.tableSchema = tableSchema;
}
- public TableFunction<T> getTableFunction() {
- return tableFunction;
+ public FunctionDefinition getFunctionDefinition() {
+ return functionDefinition;
}
- public List<ResolvedExpression> getParameters() {
- return parameters;
+ public FunctionIdentifier getFunctionIdentifier() {
+ return functionIdentifier;
}
- public TypeInformation<T> getResultType() {
- return resultType;
+ public List<ResolvedExpression> getParameters() {
Review comment:
can we call it "arguments" everywhere consistently? also in the `call(...,
params)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
