twalthr commented on a change in pull request #11280: [FLINK-16377][table]
Support inline user defined functions in expression dsl
URL: https://github.com/apache/flink/pull/11280#discussion_r397266524
##########
File path:
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/expressions/resolver/ExpressionResolverTest.java
##########
@@ -157,20 +161,79 @@
DataTypes.BOOLEAN()
)),
- TestSpec.test("Lookup system function call")
+ TestSpec.test("Lookup legacy scalar function call")
.inputSchemas(
TableSchema.builder()
.field("f0", DataTypes.INT())
.build()
)
- .lookupFunction("func", new
ScalarFunctionDefinition("func", new ScalarFunc()))
+ .lookupFunction("func", new
ScalarFunctionDefinition("func", new LegacyScalarFunc()))
.select(call("func", 1, $("f0")))
.equalTo(new CallExpression(
FunctionIdentifier.of("func"),
- new ScalarFunctionDefinition("func",
new ScalarFunc()),
+ new ScalarFunctionDefinition("func",
new LegacyScalarFunc()),
Arrays.asList(valueLiteral(1), new
FieldReferenceExpression("f0", DataTypes.INT(), 0, 0)),
DataTypes.INT().bridgedTo(Integer.class)
- )));
+ )),
+
+ TestSpec.test("Lookup system function call")
+ .inputSchemas(
+ TableSchema.builder()
+ .field("f0", DataTypes.INT())
+ .build()
+ )
+ .lookupFunction("func", new ScalarFunc())
+ .select(call("func", 1, $("f0")))
+ .equalTo(new CallExpression(
+ FunctionIdentifier.of("func"),
+ new ScalarFunc(),
+ Arrays.asList(valueLiteral(1), new
FieldReferenceExpression("f0", DataTypes.INT(), 0, 0)),
+
DataTypes.INT().notNull().bridgedTo(int.class)
+ )),
+
+ TestSpec.test("Lookup catalog function call")
+ .inputSchemas(
+ TableSchema.builder()
+ .field("f0", DataTypes.INT())
+ .build()
+ )
+ .lookupFunction(ObjectIdentifier.of("cat",
"db", "func"), new ScalarFunc())
+ .select(call("cat.db.func", 1, $("f0")))
+ .equalTo(new CallExpression(
Review comment:
nit: a new line for every `new Call`? like below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
