Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1434#issuecomment-162532182
Very nice, I haven't yet gone through the code in detail but from the
description and doc it looks very good.
One thing I was confused about is the naming of the config options:
```
state.backend.savepoints: filesystem
state.backend.savepoints.fs.dir: hdfs:///flink/savepoints
```
I think this could confuse users into thinking that a different state
backend is used on the task manager to store the actual checkpoint data. If I'm
not mistaken this is purely a JobManager thing, though. Also, before the naming
scheme for stuff in `state.backend` was that `state.backend.x.y` was the
setting of option `y` for state backend `x`. Now it looks like there is a state
backend `savepoints`. Maybe we could change this to:
```
savepoints.state.backend: filesystem
savepoints.state.backend.fs.dir: hdfs:///flink/savepoints
```
to clarify that this is changing the state backend settings for the
savepoints on the JobManager.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
