Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1434#discussion_r46840304
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -630,6 +638,136 @@ protected int cancel(String[] args) {
                }
        }
     
    +   /**
    +    * Executes the SAVEPOINT action.
    +    *
    +    * @param args Command line arguments for the cancel action.
    +    */
    +   protected int savepoint(String[] args) {
    +           LOG.info("Running 'savepoint' command.");
    +
    +           SavepointOptions options;
    +           try {
    +                   options = CliFrontendParser.parseSavepointCommand(args);
    +           }
    +           catch (CliArgsException e) {
    +                   return handleArgException(e);
    +           }
    +           catch (Throwable t) {
    +                   return handleError(t);
    +           }
    +
    +           // evaluate help flag
    +           if (options.isPrintHelp()) {
    +                   CliFrontendParser.printHelpForCancel();
    +                   return 0;
    +           }
    +
    +           if (options.isDispose()) {
    +                   // Discard
    +                   return disposeSavepoint(options, 
options.getDisposeSavepointPath());
    +           }
    +           else {
    +                   // Trigger
    +                   String[] cleanedArgs = options.getArgs();
    +                   JobID jobId;
    +
    +                   if (cleanedArgs.length > 0) {
    +                           String jobIdString = cleanedArgs[0];
    +                           try {
    +                                   jobId = new 
JobID(StringUtils.hexStringToByte(jobIdString));
    +                           }
    +                           catch (Exception e) {
    +                                   LOG.error("Error: The value for the Job 
ID is not a valid ID.");
    +                                   System.out.println("Error: The value 
for the Job ID is not a valid ID.");
    +                                   return 1;
    +                           }
    +                   }
    +                   else {
    +                           LOG.error("Missing JobID in the command line 
arguments.");
    --- End diff --
    
    Same here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to