Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1437#discussion_r46836934
--- Diff:
flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java
---
@@ -563,37 +559,44 @@ public void notifyCheckpointComplete(long
checkpointId) throws Exception {
LOG.warn("Received confirmation for
unknown checkpoint id {}", checkpointId);
return;
}
-
- checkpointOffsets = (long[])
pendingCheckpoints.remove(posInMap);
+
+ //noinspection unchecked
+ checkpointOffsets =
(HashMap<KafkaTopicPartition, Long>) pendingCheckpoints.remove(posInMap);
+
// remove older checkpoints in map
for (int i = 0; i < posInMap; i++) {
pendingCheckpoints.remove(0);
}
}
-
- if (LOG.isInfoEnabled()) {
- LOG.info("Committing offsets {} to offset
store: {}", Arrays.toString(checkpointOffsets), offsetStore);
+ if(checkpointOffsets.size() == 0) {
--- End diff --
I think this is a bug. If the list is empty after you remove the checkpoint
to commit, it only means that no pending checkpoint was subsumed. It should
still commit the offsets to Kafka.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
