Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1437#discussion_r46837638
--- Diff:
flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java
---
@@ -563,37 +559,44 @@ public void notifyCheckpointComplete(long
checkpointId) throws Exception {
LOG.warn("Received confirmation for
unknown checkpoint id {}", checkpointId);
return;
}
-
- checkpointOffsets = (long[])
pendingCheckpoints.remove(posInMap);
+
+ //noinspection unchecked
+ checkpointOffsets =
(HashMap<KafkaTopicPartition, Long>) pendingCheckpoints.remove(posInMap);
+
// remove older checkpoints in map
for (int i = 0; i < posInMap; i++) {
pendingCheckpoints.remove(0);
}
}
-
- if (LOG.isInfoEnabled()) {
- LOG.info("Committing offsets {} to offset
store: {}", Arrays.toString(checkpointOffsets), offsetStore);
+ if(checkpointOffsets.size() == 0) {
+ LOG.info("Checkpoint state was empty.");
+ return;
}
// build the map of (topic,partition) -> committed
offset
- Map<TopicPartition, Long> offsetsToCommit = new
HashMap<>();
- for (TopicPartition tp : subscribedPartitions) {
-
- int partition = tp.partition();
- long offset = checkpointOffsets[partition];
- long lastCommitted = commitedOffsets[partition];
-
+ Map<KafkaTopicPartition, Long> offsetsToCommit = new
HashMap<>();
+ for (KafkaTopicPartition tp : subscribedPartitions) {
+ Long offset = checkpointOffsets.get(tp);
+ Long lastCommitted = commitedOffsets.get(tp);
+ if(lastCommitted == null) {
+ lastCommitted = OFFSET_NOT_SET;
+ }
if (offset != OFFSET_NOT_SET) {
if (offset > lastCommitted) {
offsetsToCommit.put(tp, offset);
- LOG.debug("Committing offset {}
for partition {}", offset, partition);
+ //noinspection unchecked
+ commitedOffsets.put(tp, offset);
+ LOG.debug("Committing offset {}
for {}", offset, tp.toString());
}
else {
- LOG.debug("Ignoring offset {}
for partition {} because it is already committed", offset, partition);
+ LOG.debug("Ignoring offset {}
for partition {} because it is already committed", offset, tp);
}
}
}
+ if(LOG.isInfoEnabled() && offsetsToCommit.size() > 0) {
--- End diff --
Is this a good thing on INFO level? Will be a lot of contents in the logs,
especially when running frequent checkpoints. I would vote to log this on
DEBUG...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
