StephanEwen edited a comment on issue #11502: [FLINK-16620] - Add attempt 
information in taskNameWithSubtask
URL: https://github.com/apache/flink/pull/11502#issuecomment-604508793
 
 
   I think this change is not as uncritical as it may seem, because it changes 
logging output and may break setups (log parsers, alerts).
   
   It is probably okay, but it would be nice if some large scale users could 
chime in here, before merging this.
   
   Side note: This PR should really have a description, because it is not as 
trivial as it may look. There is often the misconception that "little code 
change" means "simple change", so can skip the description. Here, like in the 
majority of changes, actually, the code is the least important thing of all. 
Let's get away from thinking of the code as the main part of a contribution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to