azagrebin commented on a change in pull request #11245: [FLINK-15794][Kubernetes] Generate the Kubernetes default image version URL: https://github.com/apache/flink/pull/11245#discussion_r398686924
########## File path: docs/ops/deployment/kubernetes.md ########## @@ -112,7 +112,7 @@ An early version of a [Flink Helm chart](https://github.com/docker-flink/example ### Session cluster resource definitions -The Deployment definitions use the pre-built image `flink:latest` which can be found [on Docker Hub](https://hub.docker.com/r/_/flink/). +The Deployment definitions use the pre-built image `flink:{{ site.version }}-scala_2.11` (or `flink:{{ site.version }}-scala_2.12`) which can be found [on Docker Hub](https://hub.docker.com/r/_/flink/). Review comment: As I mentioned this change is not strictly related to the JIRA at hand, as it is about standalone kubernetes deployment and not about the native kubernetes image option. It seems this `site.version` is not reliable at the moment. I agree with @wangyang0918, this can bring a confusion. I still think we should create another issue for this doc change which depends on 2 problems to be resolved: - the image Flink version should point to the latest minor version, - there are no Flink snapshot versions in docker hub at the moment so master doc will point to a not existing image. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
