azagrebin commented on a change in pull request #11245:
[FLINK-15794][Kubernetes] Generate the Kubernetes default image version
URL: https://github.com/apache/flink/pull/11245#discussion_r400035133
##########
File path: flink-runtime/pom.xml
##########
@@ -402,6 +402,59 @@ under the License.
</configuration>
</plugin>
+ <plugin>
+
<groupId>com.google.code.maven-replacer-plugin</groupId>
Review comment:
We synced offline with @zentol. In general, we agree that this is a cleaner
way to go as we explicitly use versions defined in one place. Nonetheless, as I
mentioned, this is a separate issue which could be a prerequisite for the
change at hand (default value of Flink image for native k8s integration). There
are some open questions to resolve in that separate issue. E.g. the setup of
most IDE projects will be broken w/o code generation as `Version` class is not
committed, so this is going to be annoying. If we commit it, it can easily
become stale then it is better to keep then "unknown" for IDE builds and
generate the actual versions into the built artefacts. Committing the actual
values all the time is also annoying, especially for the git data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
