StephanEwen commented on a change in pull request #10487:
[FLINK-15100][connector/source] Add a base implementation for SourceReader.
URL: https://github.com/apache/flink/pull/10487#discussion_r398755768
##########
File path:
flink-core/src/main/java/org/apache/flink/api/connector/source/SourceReaderContext.java
##########
@@ -38,8 +36,6 @@ Licensed to the Apache Software Foundation (ASF) under one
* Send a source event to the source coordinator.
*
* @param sourceEvent the source event to coordinator.
- * @return a completable future which will be completed either the
event has been successfully sent
- * or failed.
*/
- CompletableFuture<Boolean> sendSourceEventToCoordinator(SourceEvent
sourceEvent);
+ void sendSourceEventToCoordinator(SourceEvent sourceEvent);
Review comment:
Just double checking: This is because transmission errors actually result in
task failures, so we don't need to worry about handling success/failure here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
