StephanEwen commented on a change in pull request #10487:
[FLINK-15100][connector/source] Add a base implementation for SourceReader.
URL: https://github.com/apache/flink/pull/10487#discussion_r398711455
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinator.java
##########
@@ -98,6 +98,8 @@
void failTask(int subtask, Throwable cause);
void failJob(Throwable cause);
+
+ int numSubtasks();
Review comment:
In the future, the parallelism may change over time (better rescaling
support, autoscaling), so if we can make the implementations such that they do
not strictly assume this number, it would be great. For batch jobs, also some
tasks are running, others not, etc. Not easy to give this value a consistent
meaning.
If we need this information nonetheless, to fairly partition the data for
the readers, then let's maybe call it `currentParallelism()` or so? And we
probably need to add a "callback" in the future that notifies of changes to the
parallelism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
